Sound advice for a source code commit frequency

A colleague of mine commented recently in a discussion on how often one should commit their source code:

commit on keyup
    - always tends to keep everything as up to the minute as possible

Classic! and yes it was tongue in cheek advice!